Hi @Jiri-Kremser - what does this comment mean?

These are the optional parameters the operation can take, I can remove that if it's confusing. Or comment better.

If you wanted an optional param wouldn't you need
def start_middleware_server_group(ems_ref, blocking = false) or something like that?

blocking is an optional param in the underlying Wildfly dmr api, but we never set it to false, so I removed the comment at all and didn't complicate the method signature with it.

@Jiri-Kremser - I'm not sure about the timeout comment either...

So is params a hash that is expected to have {:blocking, :timeout} as possible keys?

correct. Possible keys that we are not using now. I am ok with removing the comments or commenting it better.

Oh duh I didn't see this timeout = params[:timeout] || 0 below
I think I'd leave the comments out and if timeout is optional, make params = {} so it is optional as well

I removed the comments and made the params hash optional arg. for couple of methods.

@Jiri-Kremser - is there a default value for :restart? I see it is false here and true below.

jboss cli says:

./jboss-cli.sh --connect ':read-operation-description(name=shutdown)'
{
    "outcome" => "success",
    "result" => {
        "operation-name" => "shutdown",
        "description" => "Shuts down the server via a call to System.exit(0)",
        "request-properties" => {
            "restart" => {
                "type" => BOOLEAN,
                "description" => "If true, once shutdown the server will be restarted again",
                "expressions-allowed" => false,
                "required" => false,
                "nillable" => true,
                "default" => false
            },
            "timeout" => {
                "type" => INT,
                "description" => "The shutdown timeout in seconds. If this is zero (the default) then the server will shutdown immediately. A value larger than zero means the server will wait up to this many seconds for all active requests to finish. A value smaller than zero means that the server will wait indefinitely for all active requests to finish.",
                "expressions-allowed" => false,
                "required" => false,
                "nillable" => true,
                "default" => 0
            }
        },
        "reply-properties" => {},
        "read-only" => false,
        "runtime-only" => true
    }
}

So the default is false, I guess the author of the code wanted to be explicit here. It's not my code btw. I only moved the methods that belongs together closer to each other. Sorry for that, the readability of the diff might be bad.